Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Increase pkg/common/utils coverage to more than 90% #948

Merged
merged 8 commits into from
Sep 19, 2023

Conversation

liuxianloveqiqi
Copy link
Contributor

@liuxianloveqiqi liuxianloveqiqi commented Sep 16, 2023

What type of PR is this?

test

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

提高对pkg/common/utils的覆盖率至90%以上

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:Increased unit test coverage for pkg/common/utils from 88.6% to 91.5%
zh(optional):提高对pkg/common/utils的单元测试,覆盖率从88.6%提高到了91.5%

(Optional) Which issue(s) this PR fixes:

#257 (comment)

(Optional) The PR that updates user documentation:

@liuxianloveqiqi liuxianloveqiqi requested review from a team as code owners September 16, 2023 09:28
@CLAassistant
Copy link

CLAassistant commented Sep 16, 2023

CLA assistant check
All committers have signed the CLA.

@liuxianloveqiqi liuxianloveqiqi changed the title Some test cases are added Increase pkg/common/utils coverage to more than 90% Sep 16, 2023
@Duslia
Copy link
Member

Duslia commented Sep 16, 2023

Well done!

@welkeyever
Copy link
Member

CI break: Run this before submit: gofumpt -l -w -extra .

@liuxianloveqiqi
Copy link
Contributor Author

CI break: Run this before submit: gofumpt -l -w -extra .

Thank you, the first time I contributed to hertz did not understand, now I have formatted the code with gofumpt and commit it now.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.05% 🎉

Comparison is base (025f404) 81.99% compared to head (9652d5f) 82.04%.

❗ Current head 9652d5f differs from pull request most recent head d02396e. Consider uploading reports for the commit d02396e to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #948      +/-   ##
===========================================
+ Coverage    81.99%   82.04%   +0.05%     
===========================================
  Files           97       97              
  Lines         9631     9631              
===========================================
+ Hits          7897     7902       +5     
+ Misses        1260     1256       -4     
+ Partials       474      473       -1     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liuxianloveqiqi
Copy link
Contributor Author

@welkeyever Branch merge request

@liuxianloveqiqi liuxianloveqiqi changed the title Increase pkg/common/utils coverage to more than 90% test: Increase pkg/common/utils coverage to more than 90% Sep 19, 2023
@liuxianloveqiqi
Copy link
Contributor Author

@li-jin-gou apply for merging,please!

Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx~

@li-jin-gou li-jin-gou merged commit a2d383f into cloudwego:develop Sep 19, 2023
@liuxianloveqiqi liuxianloveqiqi deleted the xian-utils-test branch September 19, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants