-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Increase pkg/common/utils coverage to more than 90% #948
test: Increase pkg/common/utils coverage to more than 90% #948
Conversation
Well done! |
CI break: Run this before submit: |
Thank you, the first time I contributed to hertz did not understand, now I have formatted the code with gofumpt and commit it now. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #948 +/- ##
===========================================
+ Coverage 81.99% 82.04% +0.05%
===========================================
Files 97 97
Lines 9631 9631
===========================================
+ Hits 7897 7902 +5
+ Misses 1260 1256 -4
+ Partials 474 473 -1 ☔ View full report in Codecov by Sentry. |
@welkeyever Branch merge request |
@li-jin-gou apply for merging,please! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx~
What type of PR is this?
test
Check the PR title.
(Optional) Translate the PR title into Chinese.
提高对
pkg/common/utils
的覆盖率至90%以上(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:Increased unit test coverage for
pkg/common/utils
from 88.6% to 91.5%zh(optional):提高对
pkg/common/utils
的单元测试,覆盖率从88.6%提高到了91.5%(Optional) Which issue(s) this PR fixes:
#257 (comment)
(Optional) The PR that updates user documentation: