Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generic): support both relative and absolute check for idl includes parse to make it compatible with generation tool #1718

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

Marina-Sakai
Copy link
Contributor

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@Marina-Sakai Marina-Sakai requested review from a team as code owners February 28, 2025 08:40
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 57.45%. Comparing base (23456d7) to head (fcb30c5).

Files with missing lines Patch % Lines
pkg/generic/thriftidl_provider.go 81.81% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1718      +/-   ##
===========================================
+ Coverage    57.40%   57.45%   +0.04%     
===========================================
  Files          408      408              
  Lines        37696    37703       +7     
===========================================
+ Hits         21640    21662      +22     
+ Misses       14739    14724      -15     
  Partials      1317     1317              
Flag Coverage Δ
integration 45.94% <0.00%> (+0.02%) ⬆️
unit 51.90% <81.81%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AsterDY
AsterDY previously approved these changes Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants