opt: set min row count of 1 for FK check WithScans #140735
Conversation
|
This change is |
mgartner
force-pushed
the
137547-clamp-fk-input-1
branch
from
36833c2 to
4442ca1
Compare
Fixes cockroachdb#137547 Release note (performance improvement): The optimizer previously selected poor indexes to perform foreign key checks in rare cases. It now selects better indexes.
mgartner
force-pushed
the
137547-clamp-fk-input-1
branch
from
4442ca1 to
3d8f549
Compare
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)
There was a problem hiding this comment.
:lgmt: Should we backport this with a session var disabled by default?
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:
pkg/sql/opt/optbuilder/mutation_builder.go line 1773 at r1 (raw file):
OutCols: outScope.colList(), ID: mb.b.factory.Metadata().NextUniqueID(), FKCheckInput: true,
nit: this also gets set for uniqueness checks, right? That's probably desirable, but makes the naming a little confusing.
Fixes #137547
Release note (performance improvement): The optimizer previously
selected poor indexes to perform foreign key checks in rare cases. It
now selects better indexes.