Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-25.1: sql: deflake TestDropDatabaseDeleteData #140766

Open
wants to merge 1 commit into
base: release-25.1
Choose a base branch
from

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Feb 8, 2025

Backport 1/1 commits from #140653 on behalf of @iskettaneh.

/cc @cockroachdb/release


This commit deflakes the test by doing two things:

  1. Delay the start of the test till after the zone config range feed has started already. This is used to avoid a race where we update system.zones before the full reconciliation of zone configs has started. The full reconciliation ignores dropped databases, and if we write to system.zones before that, our write might not be reconciled. By delaying the test until the zone config range feed starts, we ensure that the full reconciliation has finished, and the range feed is ready to stream our changes.

  2. Relaxes the test expectation that only the first table gets purged first. This is because there there is a race between the splits and GC queue where range might get GCed before splitting. This is more likely to happen in this test since increase the GC queue scan rate.

Release note: None

Fixes: #138185


Release justification:

This commit deflakes the test by doing two things:

1. Delay the start of the test till after the zone config range feed has
started already. This is used to avoid a race where we update
`system.zones` before the full reconciliation of zone configs has
started. The full reconciliation ignores dropped databases, and if we
write to `system.zones` before that, our write might not be reconciled.
By delaying the test until the zone config range feed starts, we ensure
that the full reconciliation has finished, and the range feed is ready
to stream our changes.

2. Turns off storage&tenant coalesce_adjacent cluster setting to avoid
a race between the split and GC queues where range might get GCed
before splitting. This is more likely to happen in this test since
increase the GC queue scan rate.

Release note: None

References: #138185
@blathers-crl blathers-crl bot requested a review from a team as a code owner February 8, 2025 00:49
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-25.1-140653 branch from 5c550f9 to 0370b52 Compare February 8, 2025 00:49
@blathers-crl blathers-crl bot requested a review from a team as a code owner February 8, 2025 00:49
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Feb 8, 2025
Copy link
Author

blathers-crl bot commented Feb 8, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested review from iskettaneh and rafiss February 8, 2025 00:49
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Feb 8, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants