Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.8.6] Optimize code size: Add an internal method ( Node.getUITransformComp ) which could be mangled to avoid invoking the code ._uiProps.uiTransformComp that could not be mangled. #18165

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

dumganhar
Copy link
Contributor

@dumganhar dumganhar commented Jan 12, 2025

Re: #18056

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

…nent which could be mangled to avoid invoking the code `._uiProps.uiTransformComp` that could not be mangled.
@dumganhar dumganhar requested a review from minggo January 12, 2025 05:49
@dumganhar dumganhar changed the title [v3.8.6] Optimize code size: Add an internal Node.getUITransformComponent which could be mangled to avoid invoking the code ._uiProps.uiTransformComp that could not be mangled. [v3.8.6] Optimize code size: Add an internal method ( Node.getUITransformComponent ) which could be mangled to avoid invoking the code ._uiProps.uiTransformComp that could not be mangled. Jan 12, 2025
Copy link

github-actions bot commented Jan 12, 2025

👍 Package size ⤵ -2596 bytes, old: 5270176, new: 5267580

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -37664,9 +37664,9 @@
              * @en Trigger ArmatureDisplay component to update render data.
              * @zh 触发 ArmatureDisplay 组件更新渲染数据。
              */
             dbUpdate(): void;
-            hasDBEventListener(type: any): boolean;
+            hasDBEventListener(type: string): boolean;
             addDBEventListener(type: string, listener: any, target: any): void;
             removeDBEventListener(type: string, listener: any, target: any): void;
             dispatchDBEvent(type: string, eventObject: any): void;
         }

@dumganhar dumganhar changed the title [v3.8.6] Optimize code size: Add an internal method ( Node.getUITransformComponent ) which could be mangled to avoid invoking the code ._uiProps.uiTransformComp that could not be mangled. [v3.8.6] Optimize code size: Add an internal method ( Node.getUITransformComp ) which could be mangled to avoid invoking the code ._uiProps.uiTransformComp that could not be mangled. Jan 12, 2025
@minggo minggo merged commit 67a0736 into cocos:v3.8.6 Jan 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants