Add Brush Script fonts and apply them to the YouTube page #2796
+1,700
−1,286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are Cursive fonts. Youtube uses Roboto (AFAIK) which is a Sans Serif font. |
|
thank you and welcome! @rishipandey2 |
|
Thank you for the feedback! @4yman-0 I agree with your suggestion about making this an optional feature. I’ll work on adding a toggle or setting to apply the font changes and update the PR soon. |
|
check our feature |
4yman-0
reviewed
Jan 28, 2025
There was a problem hiding this comment.
Approved. Your code editor started formatting on its own :)
4yman-0
approved these changes
Jan 28, 2025
This comment was marked as outdated.
This comment was marked as outdated.
4yman-0
approved these changes
Jan 28, 2025
4yman-0
reviewed
Jan 28, 2025
|
|
||
| // Call the function on load and when the setting changes | ||
| extension.features.applyCustomFonts(); | ||
| browser.storage.onChanged.addListener(function (changes, area) { |
There was a problem hiding this comment.
Suggested change
| browser.storage.onChanged.addListener(function (changes, area) { | |
| extension.storage.onChanged.addListener(function (changes, area) { |
There was a problem hiding this comment.
Okay @4yman-0 I have changed it according to your suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2793
Summary of Changes:
Details:
BrushScriptMT.ttf,BrushScriptStd.ttf) in thefontsdirectory.@font-facerules in the CSS for proper loading and usage of the fonts.