fix: Separate header render from main app #3401
Conversation
Bundle ReportChanges will increase total bundle size by 82 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3401 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 809 809
Lines 14275 14275
Branches 3935 3934 -1
=======================================
Hits 14154 14154
Misses 112 112
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3401 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 809 809
Lines 14275 14275
Branches 3935 3941 +6
=======================================
Hits 14154 14154
Misses 112 112
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3401 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 809 809
Lines 14275 14275
Branches 3935 3934 -1
=======================================
Hits 14154 14154
Misses 112 112
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3401 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 809 809
Lines 14275 14275
Branches 3942 3941 -1
=======================================
Hits 14154 14154
Misses 112 112
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 82 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
| @@ -1,20 +1,20 @@ | |||
| import * as Sentry from '@sentry/browser' | |||
| import { render, screen } from '@testing-library/react' | |||
| import { MemoryRouter, Route } from 'react-router-dom' | |||
| import { vi } from 'vitest' | |||
There was a problem hiding this comment.
the changes in this file are to convert to TS
Our main BaseLayout has an ErrorBoundary and Suspense wrapper for all the react-query suspense: true calls in all the components children of our main app. If there is an error in any of those, it bubbles up the tree and displays the specified error fallback (e.g., upside down umbrella) instead of anything in that tree.
So in this PR, moving over the Header and Global Top Banners to their own separate suspsense/errorBoundary wrapper, so that tree renders where possible, independent of any error in the main app tree.
Closes codecov/engineering-team#2460