Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP FYST-1792 filing status is sometimes nil part 2 #5584

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

WIP FYST-1792 filing status is sometimes nil part 2 #5584

wants to merge 2 commits into from

Conversation

jenny-heath
Copy link
Contributor

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Added a before action to catch people who try to load a page after data transfer without any df data (this can happen if they start intake over in a new tab and then refresh a page they used to have access to)
  • Depends on a new trait added to navigation section
  • Still need to add it to non-AZ navigation sections

How to test?

  • Added a shared example and am contemplating adding it to like...all the controllers?

jenny-heath and others added 2 commits February 13, 2025 16:58
@github-actions GitHub Actions
Copy link

Heroku app: https://gyr-review-app-5584-12588cebfca8.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5584 (optionally add --tail)

arinchoi03
arinchoi03 reviewed Feb 14, 2025
View reviewed changes
app/lib/navigation/state_file_az_question_navigation.rb
@@ -44,11 +44,11 @@ class StateFileAzQuestionNavigation < Navigation::StateFileBaseQuestionNavigatio
Navigation::NavigationStep.new(StateFile::Questions::TaxesOwedController),
Navigation::NavigationStep.new(StateFile::Questions::TaxRefundController),
Navigation::NavigationStep.new(StateFile::Questions::EsignDeclarationController), # creates EfileSubmission and transitions to preparing
]),
], false, true),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just highlighting something that i mentioned in the story that StateFile::Questions::PostDataTransferController can be currently in a state where df data doesnt exist -- it redirects the user to the data-import failed page if it failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arinchoi03 arinchoi03 arinchoi03 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jenny-heath @arinchoi03