-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and update the create/find campaign flow #447
base: master
Are you sure you want to change the base?
Conversation
Things to look for. Does the routing work in different auth states. Does FirebaseInitialSearch or other parts of the store need to be cleared at any point> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good as far as I can tell.
…on SubmitButton optional to avoid undefined prop error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid work on the routing refactor. Everything seems to be working as expected. A couple things we may want to polish off before merging into master/production:
- Add styles to Login component
- Maybe: In the case where a user is not logged in but tries to access a protected route, should the AuthenticatedRoutes component first pop off the most recent protected route from the router stack before pushing the Login path on top? This way when a user tries to navigate backward after being redirected to the Login screen by using the back button of the browser, they will go to the route that they were on before attempting to access the protected route instead of navigating back to the protected route and immediately being redirected to Login again.
What does this PR do?
Render
prefixhandleRedirectToExistingCampaign
=> redirects to new/existing-campaign
routehandleRenderNearbyCampaigns
=> currently not handled (may come back to it in the future)handleRenderNewCampaign
=> redirects to new/create-campaign
route/create-campaign
route require authentication using the above component (Closes Handle UI for create campaign when not logged in #440)