fix after audit

codefox-inc · Oct 11, 2024 · bc5290c · bc5290c
1 parent 40cc241
commit bc5290c
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 9 deletions.
diff --git a/script/DeployNft.s.sol b/script/DeployNft.s.sol
@@ -7,7 +7,9 @@ import {console, Script} from "forge-std/Script.sol";
 import {AmbassadorNft} from "src/AmbassadorNft.sol";
 
 contract DeployNft is Script {
-    function setUp() public {
+    function run() public {
         vm.startBroadcast();
+
+        vm.stopBroadcast();
     }
 }
diff --git a/src/GovToken.sol b/src/GovToken.sol
@@ -36,7 +36,6 @@ contract GovToken is ERC20, ERC20Burnable, AccessControl, ERC20Permit, ERC20Vote
         _grantRole(DEFAULT_ADMIN_ROLE, defaultAdmin);
         _grantRole(MINTER_ROLE, minter);
         _grantRole(BURNER_ROLE, burner);
-        _grantRole(BURNER_ROLE, burner);
         // votingPowerExchange role is supposed to be only granted to VotingPowerExchange contract
         _grantRole(VOTING_POWER_EXCHANGE_ROLE, votingPowerExchange);
     }

diff --git a/src/VotingPowerExchange.sol b/src/VotingPowerExchange.sol
@@ -20,8 +20,6 @@ contract VotingPowerExchange is AccessControl, EIP712 {
 
     // Errors
     error VotingPowerExchange__DefaultAdminCannotBeZero();
-    error VotingPowerExchange__AmountIsZero();
-    error VotingPowerExchange__HighestIdIsTooHigh();
     error VotingPowerExchange__AddressIsZero();
     error VotingPowerExchange__GovOrUtilAddressIsZero();
     error VotingPowerExchange__AmountIsTooSmall();
@@ -44,7 +42,6 @@ contract VotingPowerExchange is AccessControl, EIP712 {
     bytes32 public constant EXCHANGER_ROLE = keccak256("EXCHANGER_ROLE");
     // PRECISION values for the calculation
     uint256 private constant PRECISION_FIX = 1e9;
-    uint256 private constant PRECISION_FACTOR = 10;
     uint256 private constant PRECISION = 1e18;
     uint256 private constant ALLOWED_EXCHANGING_MINIMUM_AMOUNT = 1e18;
 
@@ -261,14 +258,12 @@ contract VotingPowerExchange is AccessControl, EIP712 {
         returns (
             bytes32 __EXCHANGE_TYPEHASH,
             uint256 _PRECISION_FIX,
-            uint256 _PRECISION_FACTOR,
             uint256 _PRECISION,
             uint256 _ALLOWED_EXCHANGING_MINIMUM_AMOUNT
         )
     {
         __EXCHANGE_TYPEHASH = _EXCHANGE_TYPEHASH;
         _PRECISION_FIX = PRECISION_FIX;
-        _PRECISION_FACTOR = PRECISION_FACTOR;
         _PRECISION = PRECISION;
         _ALLOWED_EXCHANGING_MINIMUM_AMOUNT = ALLOWED_EXCHANGING_MINIMUM_AMOUNT;
     }

diff --git a/test/integration/VotingPowerExchange.t.sol b/test/integration/VotingPowerExchange.t.sol
@@ -232,7 +232,6 @@ contract VotingPowerExchangeTest is Test {
         (
             bytes32 __EXCHANGE_TYPEHASH,
             uint256 _PRICISION_FIX,
-            uint256 _PRICISION_FACTOR,
             uint256 _PRICISION,
             uint256 _ALLOWED_EXCHANGING_MINIMUM_AMOUNT
         ) = votingPowerExchange.getConstants();
@@ -241,7 +240,6 @@ contract VotingPowerExchangeTest is Test {
             __EXCHANGE_TYPEHASH, keccak256("Exchange(address sender,uint256 amount,bytes32 nonce,uint256 expiration)")
         );
         assertEq(_PRICISION, 1e18);
-        assertEq(_PRICISION_FACTOR, 10);
         assertEq(_PRICISION_FIX, 1e9);
         assertEq(_ALLOWED_EXCHANGING_MINIMUM_AMOUNT, 1e18);
     }