Skip to content

Commit

Permalink
fix: prevent build logs from crashing envbox process (#95)
Browse files Browse the repository at this point in the history
- While not pushing build logs results in a degraded experience
  it shouldn't prevent workspace startup.
  • Loading branch information
sreya authored Aug 22, 2024
1 parent a27862d commit 9b6f446
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions cli/docker.go
Original file line number Diff line number Diff line change
Expand Up @@ -180,13 +180,15 @@ func dockerCmd(ch chan func() error) *cobra.Command {

agent, err := buildlog.OpenCoderClient(ctx, coderURL, log, flags.agentToken)
if err != nil {
return xerrors.Errorf("open coder client: %w", err)
// Don't fail workspace startup on
// an inability to push build logs.
log.Error(ctx, "failed to instantiate coder build log client, no logs will be pushed", slog.Error(err))
} else {
blog = buildlog.MultiLogger(
buildlog.OpenCoderLogger(ctx, agent, log),
blog,
)
}

blog = buildlog.MultiLogger(
buildlog.OpenCoderLogger(ctx, agent, log),
blog,
)
}
defer blog.Close()

Expand Down

0 comments on commit 9b6f446

Please sign in to comment.