Update list submission template to match new wagtail update template #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Considering our 4.0 supports any version of Wagtail 6.x, I don't think we would want to backport it to that version since there's a chance it could reverse-break on wagtail 6.0. Thoughts? We will definitely want it in 4.1 though. |
|
It seems our options are either we drop support for 6.0 in 4.1, or we add a second template and a version check that provides the template based on wagtail version. Or honestly both, if we want to support this particular overlap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing! Please follow the guidelines below to submit your
pull request. Additional details are available in our
Contributor Guide.
Description of change
The
wagtailforms/list_submissions.htmltemplate is customized to use/respect protected media. This was changed in Wagtail 6.1, but was not updated to match in the CRX, causing pagination to fail to appear.