Fix Card Footer #668
Open
Fix Card Footer #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsalvino
reviewed
Dec 30, 2024
| {% include_block button %} | ||
| {% endfor %} | ||
| </div> | ||
| {% for button in self.links %} |
There was a problem hiding this comment.
I think it would be best to leave the for-loop inside the div, and replace this with an {% if self.links %} check.
For example, if there are two buttons, they should render side by side. This change would make them render in two separate footers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the default card template to hide the card-footer div if a link is not added. Current shows an empty section which shouldn't be visible if there is no link:
Improved version hides the card footer if no link has been specified in the Wagtail editor: