Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notifications): new notification pattern #651

Merged
merged 23 commits into from
Feb 2, 2025
Merged

feat(notifications): new notification pattern #651

merged 23 commits into from
Feb 2, 2025

Conversation

e11sy
Copy link
Contributor

@e11sy e11sy commented Feb 1, 2025

This PR is a part of work on new notification model
check related PRs in:

Changes

  • Now we have GraphQL mutation for notification rule deletion
  • Now we have optional threshold and thresholdPeriod fields of the notificationRule used for WhatToReceive.SEEN_MORE state
  • Added WhatToReceive.SEEN_MORE state and removed WhatToReceive.ALL
  • Added Frequency based notifications pattern customization in addNotificationRule form
  • Improved channels endpoint validation with regular expressions

Bonus

  • Now RadioButtonGroup has description slot that could be rendered if props.description is not defined
  • Analytics module does not init if user is not defined

e11sy added 21 commits January 25, 2025 18:39
@e11sy
fix(components): fix CustomSelect filteredOption computed
5d3880c 
filteredOption was filtering by link to the objects, which not allowed to pass value with same ['id', 'name', 'value'] and got correct filter (because it is different object with different pointer)

So we should filter objects by id
@e11sy
imp(components): RadioButtonGroup descriptions presentation improved
9e79c76 
Added optional slot for description presentation if description option is undefined, we could pass description via component which would be displayed in description slot
@e11sy
feat(components): added NotificationAddRule form for SEEN_MORE setting
e649da7 
Added threshold and thresholdPeriod form and validation
@e11sy
chore(i18n): update dictionaries
77239b8
@e11sy
types(notifications): update notification types
3bf101d
@e11sy
chore(storybook): change ReceiveTypes from ALL to SEEN_MORE
55d7cd5
@e11sy
types(project-notifications): add threshold types
fa78667
@e11sy
chore(i18n): update dictionaries
8f6d3f4
@e11sy
chore(i18n): update translation usage
cd8d0fb
@e11sy
fix(components): add notification rule form watchers
b7f0a7e
@e11sy
fix(components): fix slot position in RadioButtonGroup
c50c826
@e11sy
chore(graphql): update schemas
a94df9e
@e11sy
chore(): migrate from enum to map
59b5045
@e11sy
chore(): remove redundant logs
a4f591c
@e11sy
imp(styles): improve create rule form styles
9b7caa8
@e11sy
imp(notifications): add channels endpoint validation in create rule form
bc1a41d
@e11sy
fix(notifications): fix build
4eca02a
@e11sy
feat(notifications): add graphql mutation for deletion of the rule
86d1ddc
@e11sy
imp(i18n): improve seen more label naming
b97281e
@e11sy
chore(): lint fix
ce63fa0
@e11sy
imp(add-rule): do not overuse hardcoded number
1193d3a
@e11sy e11sy merged commit 39e088b into master Feb 2, 2025
2 checks passed
@e11sy e11sy deleted the new-notification-pattern branch February 2, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc neSpecc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e11sy @neSpecc