-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.29.x] Upgrade Solr & Zookeeper #6845
base: 2.29.x
Are you sure you want to change the base?
Conversation
build now |
Internal build has been started, your results will be available at build completion. |
Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI. |
build now |
Internal build has been started, your results will be available at build completion. |
Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI. |
Internal build has been started, your results will be available at build completion. |
Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI. |
<bundle>mvn:org.eclipse.jetty.http2/http2-client/${jetty.version}</bundle> | ||
<bundle>mvn:org.eclipse.jetty.http2/http2-http-client-transport/${jetty.version}</bundle> | ||
<bundle>mvn:org.eclipse.jetty/jetty-client/${solr.jetty.version}</bundle> | ||
<bundle>mvn:org.eclipse.jetty/jetty-alpn-client/${solr.jetty.version}</bundle> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add the jetty-alpn-java-client here as well since that is actually needed for JDK 9+ environments or is that no longer needed with this upgrade? Not all environments appear to need this but some certainly do if using the http2 client under the hood.
<bundle>mvn:org.eclipse.jetty/jetty-alpn-java-client/${solr.jetty.version}</bundle>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added 👍
What does this PR do?
Cherry-pick upgrade solr commits from the 3.x branch + upgrade to the latest zookeeper to resolve the zookeeper CVEs
How should this be tested?
Run
mvn org.commonjava.maven.plugins:directory-maven-plugin:highest-basedir@directories dependency-check:aggregate -B -pl '!distribution/docs, !platform/admin/modules/admin-modules-docs' -P '!itests'
on project and ensure that zookeeper does not show up in CVE list.Who is reviewing it?
@zkirksey
@glenhein
Select relevant component teams:
@codice/solr
Ask 2 committers to review/merge the PR and tag them here.
@jlcsmith
@derekwilhelm
Checklist:
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend: