window: fixed boolean errors in if conditions #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nFrame and windowGeometrySaver.record
kkoreilly
reviewed
Jan 30, 2025
core/windowgeometry.go
Outdated
| @@ -257,7 +257,8 @@ func (ws *windowGeometrySaver) record(win *renderWindow) { | |||
| } | |||
| sc := win.SystemWindow.Screen() | |||
| pos := win.SystemWindow.Position(sc) | |||
| if TheApp.Platform() == system.Windows && pos.X == -32000 || pos.Y == -32000 { // windows badness | |||
| // TODO: come up with better name for a -32000 constant | |||
There was a problem hiding this comment.
Thank you for this contribution! If you want, it would be great if you could add a system.WindowsMinimizedPosition constant or similar.
There was a problem hiding this comment.
@kkoreilly i've updated pr and added some new changes are supposed to make related code more logical and clear.
There was a problem hiding this comment.
i can revert those changes and just use system.WindowsMinimizedPosition if any.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
affected functions: Window.ConstrainFrame and windowGeometrySaver.record.
Fixes #1465