chore(gen): remove deprecated swagger-typescript-api-nextgen #1268
Conversation
polomani
changed the title
|
@andersfylling could you have a look if there is an easy way to fix failing tests? |
the maintainer just went afk for a long while, so made the switch. Seems it's active again 🙏 |
|
what had happened was that the updated library had some changes to formatting and supports more openapi features, so we had to update the expected output files to match this. Some of the tests will generate some typescript definitions from openapi yaml, and match that against an expected output file (which we now updated to include the newer features). |
| */ | ||
| attributes?: Record< | ||
| string, | ||
| | ({ |
There was a problem hiding this comment.
this looks kind of weird?
There was a problem hiding this comment.
agree this seems broken (initially was correct)
There was a problem hiding this comment.
@andersfylling can we override this type somehow?
There was a problem hiding this comment.
I'll have a look again later today
|
@marvrez or @miladcognite can you verify the changes to vision? |
|
@peetcremer1 or @olacognite can you verify changes to annotations? |
| description?: string; | ||
| type: 'boolean'; | ||
| type: boolean; |
There was a problem hiding this comment.
string was correct here
| externalId?: string; | ||
| }; | ||
| /** | ||
| * primitives.attributes.Boolean |
There was a problem hiding this comment.
do you know if we can remove these primitives.attributes annotations? they seem useless
@andersfylling
swagger-typescript-api-nextgen (fork) was deprecated a long time ago, we need to replace it with the well-maintained swagger-typescript-api (helps with getting rid of CVEs)