[V8] change requests to httpx
#2090
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haakonvt
force-pushed
the
change-to-httpx
branch
2 times, most recently
from
d487c2a to
c9d2a04
Compare
haakonvt
force-pushed
the
change-to-httpx
branch
4 times, most recently
from
51dd867 to
00a0156
Compare
haakonvt
force-pushed
the
change-to-httpx
branch
from
00a0156 to
ac989ae
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v8-release #2090 +/- ##
===========================================
Coverage 90.37% 90.37%
===========================================
Files 152 154 +2
Lines 23117 23145 +28
===========================================
+ Hits 20891 20918 +27
- Misses 2226 2227 +1
|
haakonvt
force-pushed
the
change-to-httpx
branch
5 times, most recently
from
1a422c8 to
87b982b
Compare
haakonvt
force-pushed
the
change-to-httpx
branch
9 times, most recently
from
622ca10 to
b76307c
Compare
haakonvt
force-pushed
the
change-to-httpx
branch
from
b76307c to
359c877
Compare
haakonvt
force-pushed
the
change-to-httpx
branch
from
359c877 to
6f810f2
Compare
Draft
- fix tests/tests_unit/test_api/test_assets.py - fix tests/tests_unit/test_api/test_data_modeling/test_containers.py - fix tests/tests_unit/test_api/test_data_sets.py - fix tests/tests_unit/test_api/test_datapoints.py - fix tests/tests_unit/test_api/test_documents.py - fix tests/tests_unit/test_api/test_entity_matching.py - fix tests/tests_unit/test_api/test_events.py - fix tests/tests_unit/test_api/test_extractionpipelines.py - fix tests/tests_unit/test_api/test_files.py (puh!) - fix tests/tests_unit/test_api/test_functions.py (mega puuh) - fix tests/tests_unit/test_api/test_iam.py - fix tests/tests_unit/test_api/test_labels.py - fix tests/tests_unit/test_api/test_raw.py - fix tests/tests_unit/test_api/test_relationships.py - fix tests/tests_unit/test_api/test_sequences.py (puh again) - fix tests/tests_unit/test_api/test_synthetic_time_series.py - fix tests/tests_unit/test_api/test_time_series.py - fix tests/tests_unit/test_api/test_vision_extract.py - fix tests/tests_unit/test_api_client.py ( 👀 ) - fix tests/tests_unit/test_cognite_client.py - fix tests/tests_unit/test_data_classes/test_capabilities.py - fix tests/tests_unit/test_http_client.py - fix tests/tests_unit/test_meta.py
haakonvt
force-pushed
the
change-to-httpx
branch
2 times, most recently
from
4219377 to
1dad953
Compare
haakonvt
commented
Mar 1, 2025
Comment on lines
+492
to
+494
| body_data: bytes = b"" | ||
| async for x in request.stream: | ||
| body_data += x |
haakonvt
force-pushed
the
change-to-httpx
branch
from
1dad953 to
19f2894
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DM-1888
So draft it hurts 😁
Update: Less draft, less hurt
Update: Should be ready for early review / feedback now 👌
TODO: