-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PYG-350] Aggregate when filter return empty #2124
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2124 +/- ##
==========================================
- Coverage 90.38% 90.37% -0.01%
==========================================
Files 152 152
Lines 23127 23125 -2
==========================================
- Hits 20903 20900 -3
- Misses 2224 2225 +1
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
if camel_case: | ||
output = convert_all_keys_recursive(output) | ||
return output | ||
return {"aggregate": self._aggregate, "property": self.property} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change isn't described by your PR description. Is it accidental, or deliberately but undocumented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small question
Description
If you add a filter to your aggregates which filters out all results the

value
will not be in the response:Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.