-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOGE-105] Robustify tests #2125
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2125 +/- ##
==========================================
+ Coverage 90.37% 90.38% +0.01%
==========================================
Files 152 152
Lines 23127 23127
==========================================
+ Hits 20900 20903 +3
+ Misses 2227 2224 -3 🚀 New features to boost your workflow:
|
Looks fine, but I would like to see the answer to @erlendvollset's comment before completing risk review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
risk review ok
Description
A few minor adjustments of tests found when setting up the contributor project.
RISK REVIEWER: Only touching tests, improving some fixtures to auto create data. -> Low risk.
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.