Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOGE-105] Robustify tests #2125

Merged
merged 4 commits into from
Mar 7, 2025
Merged

[DOGE-105] Robustify tests #2125

merged 4 commits into from
Mar 7, 2025

Conversation

doctrino
Copy link
Contributor

@doctrino doctrino commented Mar 1, 2025

Description

A few minor adjustments of tests found when setting up the contributor project.

RISK REVIEWER: Only touching tests, improving some fixtures to auto create data. -> Low risk.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.38%. Comparing base (c37796e) to head (2cbdb92).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2125      +/-   ##
==========================================
+ Coverage   90.37%   90.38%   +0.01%     
==========================================
  Files         152      152              
  Lines       23127    23127              
==========================================
+ Hits        20900    20903       +3     
+ Misses       2227     2224       -3     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@doctrino doctrino changed the title Robustify tests [DOGE-105] Robustify tests Mar 1, 2025
@doctrino doctrino marked this pull request as ready for review March 1, 2025 21:24
@doctrino doctrino requested review from a team as code owners March 1, 2025 21:24
@doctrino doctrino requested review from a team and larshagencognite and removed request for a team March 1, 2025 21:25
@doctrino doctrino enabled auto-merge (squash) March 1, 2025 21:26
haakonvt
haakonvt previously approved these changes Mar 6, 2025
@larshagencognite
Copy link

Looks fine, but I would like to see the answer to @erlendvollset's comment before completing risk review.

Copy link
Collaborator

@erlendvollset erlendvollset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@larshagencognite larshagencognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

risk review ok

@doctrino doctrino merged commit 596b9f0 into master Mar 7, 2025
17 checks passed
@doctrino doctrino deleted the update-tests branch March 7, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants