Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dedicated cdf test project for CD workflow #2128

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

erlendvollset
Copy link
Collaborator

@erlendvollset erlendvollset commented Mar 6, 2025

Using a dedicated cdf project for CD workflow for 2 reasons:

  • No longer want a test project in staging since it's less stable
  • Don't want devs to have write access to this project, so that we don't risk breaking master builds and we force devs to create test fixtures for setting up their data instead of ingesting it manually.

Variables and secrets have been updated accordingly through the github UI.

@erlendvollset erlendvollset requested review from a team as code owners March 6, 2025 13:28
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.43%. Comparing base (01e65f4) to head (f870fc7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2128      +/-   ##
==========================================
+ Coverage   90.38%   90.43%   +0.05%     
==========================================
  Files         152      152              
  Lines       23127    23127              
==========================================
+ Hits        20903    20916      +13     
+ Misses       2224     2211      -13     

see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erlendvollset erlendvollset force-pushed the cd-prod-project branch 5 times, most recently from 0876731 to 264f840 Compare March 6, 2025 13:41
@doctrino doctrino self-requested a review March 6, 2025 14:21
@erlendvollset erlendvollset requested review from a team and finnag and removed request for a team March 6, 2025 14:43
Copy link

@finnag finnag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄

@erlendvollset erlendvollset merged commit c37796e into master Mar 6, 2025
17 checks passed
@erlendvollset erlendvollset deleted the cd-prod-project branch March 6, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants