Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run group update in contributor and prod project. #2131

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Run group update in contributor and prod project. #2131

merged 2 commits into from
Mar 7, 2025

Conversation

doctrino
Copy link
Contributor

@doctrino doctrino commented Mar 7, 2025

Description

Setup the runner to update Groups in the contributor and prod projects.

Removed the scripts/add_capability.py as the new way should be as described here contributing.md

Tested locally with the integration runner credentials.

Comment on lines +24 to +25
PROVIDER: "entra_id"
LOGIN_FLOW: "client_credentials"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicitly setting these.

@doctrino doctrino marked this pull request as ready for review March 7, 2025 12:32
@doctrino doctrino requested review from a team as code owners March 7, 2025 12:32
@doctrino doctrino requested review from a team and psalaberria002 and removed request for a team March 7, 2025 12:38
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.40%. Comparing base (596b9f0) to head (9f9cd6a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2131      +/-   ##
==========================================
+ Coverage   90.37%   90.40%   +0.03%     
==========================================
  Files         152      152              
  Lines       23127    23127              
==========================================
+ Hits        20902    20909       +7     
+ Misses       2225     2218       -7     

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@erlendvollset erlendvollset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@psalaberria002 psalaberria002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄

@doctrino doctrino merged commit 11cf2b4 into master Mar 7, 2025
17 checks passed
@doctrino doctrino deleted the fix-ci branch March 7, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants