Make error in authenticator a little clearer #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikezedev
approved these changes
Mar 5, 2025
einarmo
requested review from
a team and
rbtcollins
and removed request for
a team
rbtcollins
reviewed
Mar 5, 2025
| @@ -119,7 +119,7 @@ impl StatusCode { | |||
| /// Set the info type, this will clear the info bits if set to NotUsed. | |||
| #[must_use = "Status code is copied, not modified in place."] | |||
| pub fn set_info_type(mut self, value: StatusCodeInfoType) -> Self { | |||
| self.0 = self.0 & !(1 << 10) | ((value as u32) & 1) << 10; | |||
| self.0 = self.0 & !(1 << 10) | (((value as u32) & 1) << 10); | |||
There was a problem hiding this comment.
Is this just for clarity? It clearly isn't affecting tests; so either the tests are insufficient, or the evaluation is unchanged.
(I don't have all the operator priorities for this in my head, sorry ;)
There was a problem hiding this comment.
Evaluation is unchanged, this is for clarity, required by a new clippy lint. Since we're building in github actions we get new rust versions automatically, which occasionally causes this.
I'm reasonably certain changing the precedence here would fail one of the tests for this type.
|
Assuming the () change is just for clarity.... approved |
|
🦄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There isn't a ton we can do to make it obvious what went wrong, since we can't really log the response from an OAuth request, but we can at least make it obvious that the error came from the authenticator. Currently you'll just get "Error in middleware: Failed to deserialize" which is less helpful.