Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start work on the unstable module #506

Merged
merged 6 commits into from
Jan 23, 2025
Merged

Start work on the unstable module #506

merged 6 commits into from
Jan 23, 2025

Conversation

einarmo
Copy link
Contributor

@einarmo einarmo commented Jan 9, 2025

Defines ConnectionConfig and some utils related to this. Lots more to do before we can actually use this for anything.

@einarmo einarmo requested a review from a team as a code owner January 9, 2025 09:09
@einarmo einarmo force-pushed the connection-config branch from 5c175a2 to 5de153a Compare January 9, 2025 10:03
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 61.01010% with 193 lines in your changes missing coverage. Please review.

Project coverage is 78.25%. Comparing base (5c940c0) to head (e37b8d8).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...xtractorUtils/Unstable/DestinationUtilsUnstable.cs 63.63% 46 Missing and 14 partials ⚠️
Cognite.Extensions/MsalAuthenticator.cs 18.05% 52 Missing and 7 partials ⚠️
Cognite.Extensions/Unstable/AuthenticatorConfig.cs 35.29% 22 Missing ⚠️
Cognite.Extensions/Authenticator.cs 72.05% 7 Missing and 12 partials ⚠️
ExtractorUtils/Cognite/CogniteDestination.cs 84.09% 10 Missing and 4 partials ⚠️
...xtractorUtils/Cognite/CogniteDestinationWithIDM.cs 79.41% 5 Missing and 2 partials ⚠️
...xtractorUtils/Unstable/Configuration/Connection.cs 56.25% 7 Missing ⚠️
ExtractorUtils/Cognite/CogniteClientExtensions.cs 58.33% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #506      +/-   ##
==========================================
- Coverage   78.86%   78.25%   -0.61%     
==========================================
  Files         114      118       +4     
  Lines       10578    10886     +308     
  Branches     1608     1655      +47     
==========================================
+ Hits         8342     8519     +177     
- Misses       1600     1704     +104     
- Partials      636      663      +27     
Files with missing lines Coverage Δ
ExtractorUtils/Cognite/DestinationUtils.cs 80.47% <ø> (+4.23%) ⬆️
ExtractorUtils/Unstable/Configuration/Cognite.cs 100.00% <100.00%> (ø)
ExtractorUtils/queues/EventUploadQueue.cs 80.00% <100.00%> (+0.95%) ⬆️
ExtractorUtils/Cognite/CogniteClientExtensions.cs 57.14% <58.33%> (-17.86%) ⬇️
...xtractorUtils/Cognite/CogniteDestinationWithIDM.cs 79.43% <79.41%> (-3.22%) ⬇️
...xtractorUtils/Unstable/Configuration/Connection.cs 56.25% <56.25%> (ø)
ExtractorUtils/Cognite/CogniteDestination.cs 78.30% <84.09%> (-0.10%) ⬇️
Cognite.Extensions/Authenticator.cs 67.09% <72.05%> (+5.83%) ⬆️
Cognite.Extensions/Unstable/AuthenticatorConfig.cs 35.29% <35.29%> (ø)
Cognite.Extensions/MsalAuthenticator.cs 37.19% <18.05%> (-14.99%) ⬇️
... and 1 more

... and 4 files with indirect coverage changes

Copy link
Contributor

@ozangoktan ozangoktan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@einarmo einarmo merged commit c4772b8 into master Jan 23, 2025
5 checks passed
@einarmo einarmo deleted the connection-config branch January 23, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants