fix(scheduler): change to single task based scheduler #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
==========================================
- Coverage 71.57% 71.35% -0.23%
==========================================
Files 33 33
Lines 3536 3501 -35
Branches 420 413 -7
==========================================
- Hits 2531 2498 -33
- Misses 848 849 +1
+ Partials 157 154 -3
|
polomani
reviewed
Mar 4, 2025
|
|
||
| // If the next occurrence is less or equal than the current UTC time (plus tolerance) | ||
| // and is greater than the last run time, trigger the simulation run. | ||
| if (nextOccurrence <= DateTime.UtcNow.Add(tolerance) && nextOccurrence > lastRun) |
There was a problem hiding this comment.
Suggested change
| if (nextOccurrence <= DateTime.UtcNow.Add(tolerance) && nextOccurrence > lastRun) | |
| if (nextOccurrence >= DateTime.UtcNow && nextOccurrence <= DateTime.UtcNow.Add(tolerance) && nextOccurrence > lastRun) |
otherwise it might fire before the actual schedule (we can't allow that)
polomani
reviewed
Mar 4, 2025
| @@ -43,50 +42,25 @@ public async Task Delay(TimeSpan delay, CancellationToken token) | |||
|
|
|||
| /// <summary> | |||
| /// Represents a scheduled job for simulation. | |||
| /// (No longer used since scheduling is now done in a single loop.) | |||
There was a problem hiding this comment.
why are you keeping it then?
polomani
reviewed
Mar 4, 2025
| // to a new configuration on the API | ||
| if (scheduledJobs.TryGetValue(routineRev.RoutineExternalId, out var job)) | ||
| // Parse the cron schedule. | ||
| CrontabSchedule schedule; |
There was a problem hiding this comment.
maybe put this into the map as well, so we don't recompute it each time?
There was a problem hiding this comment.
could probably repurpose ScheduledJob for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current scheduler has a dotnet
Taskfor each routine revision. This leads to problems when a large number of RoutineRevisions are scheduled at the exact same time every hour. This PR changes the approach so we dont create Tasks at all, rather have just oneTaskthat keeps waking up every minute and goes through all the routines in the state to decide which needs to be scheduled based on their cron expression.