Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cleanup for old model revisions and remove tmp state #241

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lpereiracgn
Copy link
Contributor

@lpereiracgn lpereiracgn commented Mar 7, 2025

Only for testing purposes. Not to be reviewed.

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

Attention: Patch coverage is 61.65414% with 51 lines in your changes missing coverage. Please review.

Project coverage is 70.96%. Comparing base (800ef10) to head (640f8dd).

Files with missing lines Patch % Lines
Cognite.Simulator.Utils/ModelLibraryBase.cs 63.20% 38 Missing and 1 partial ⚠️
...ulator.Utils/DefaultClasses/DefaultModelLibrary.cs 16.66% 5 Missing ⚠️
Cognite.Simulator.Utils/Configuration.cs 20.00% 3 Missing and 1 partial ⚠️
Cognite.Simulator.Utils/FileState.cs 81.25% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
- Coverage   71.83%   70.96%   -0.87%     
==========================================
  Files          33       33              
  Lines        3554     3627      +73     
  Branches      422      434      +12     
==========================================
+ Hits         2553     2574      +21     
- Misses        844      896      +52     
  Partials      157      157              
Files with missing lines Coverage Δ
Cognite.Simulator.Utils/SimulationRunnerBase.cs 72.56% <ø> (-0.10%) ⬇️
Cognite.Simulator.Utils/FileState.cs 86.39% <81.25%> (-0.63%) ⬇️
Cognite.Simulator.Utils/Configuration.cs 70.73% <20.00%> (-1.43%) ⬇️
...ulator.Utils/DefaultClasses/DefaultModelLibrary.cs 29.72% <16.66%> (+0.31%) ⬆️
Cognite.Simulator.Utils/ModelLibraryBase.cs 70.73% <63.20%> (-4.45%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant