Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong types, not ignoring the VALUE parameter, better error handling #331

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

thet
Copy link
Member

@thet thet commented Oct 13, 2021

Continuation of #196
See old PR for comments.

@mister-roboto
Copy link

@thet thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@thet
Copy link
Member Author

thet commented Oct 13, 2021

@jenkins-plone-org please run jobs

stlaz and others added 7 commits October 15, 2021 15:06
Previously, if error occured during the creation of inner
type instance from iCalendar string, the error with the
name of the bogus property would be stored in the
appropriate component's errors attribute along with the error
string  but the property's value would be removed from the
parsed representation. This patch keeps the value even with its
parameters at that certain property, the value's type is changed
to vText.

Should allow implementation of
#158

Improves
#174
@thet
Copy link
Member Author

thet commented Oct 15, 2021

@jenkins-plone-org please run jobs

1 similar comment
@thet
Copy link
Member Author

thet commented Oct 15, 2021

@jenkins-plone-org please run jobs

@niccokunzmann
Copy link
Member

@thet, we are in the process of setting up maintenance for this repository again, see #360. It will take some time but I hope, we will get further towards integrating your changes. Thanks a lot for the effort and patience already!
If you like to run the latest tests for this PR, you can rebase/merge master.

Some old Python versions get dropped in the master branch, so you might well be able to live out some new typing features!

@niccokunzmann
Copy link
Member

niccokunzmann commented Aug 22, 2022

I am merging this so the tests run. However, I have no idea about the modifications. I commented your fix out, so the tests will hopefully fail.
https://github.com/collective/icalendar/runs/7952093866?check_suite_focus=true#step:6:76
Yes....

@geier
Copy link
Collaborator

geier commented Aug 23, 2022

@niccokunzmann the original issue is #187, there was a lot of discussion on this in #196

The main issue is that we currently parse invalid icalendar strings without any error message, i.e. with a wrong date type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants