Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bad replace in parser.py. #694

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

mtrd3v
Copy link
Contributor

@mtrd3v mtrd3v commented Jul 15, 2024

This pull request fixes issue #525, where there was a bad replace in parser.py


📚 Documentation preview 📚: https://icalendar--694.org.readthedocs.build/

@coveralls
Copy link

coveralls commented Jul 15, 2024

Pull Request Test Coverage Report for Build 9955942316

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.376%

Totals Coverage Status
Change from base Build 9858096109: 0.003%
Covered Lines: 3154
Relevant Lines: 3239

💛 - Coveralls

@niccokunzmann
Copy link
Member

@mtr-d3v Thanks for this! Could you add a changelog entry? This perfect otherwise. Thanks for also testing this!

@mtrd3v
Copy link
Contributor Author

mtrd3v commented Jul 16, 2024

Thanks for reviewing my PR. I have included the requested changelog entry.

@niccokunzmann niccokunzmann merged commit bde1275 into collective:main Jul 17, 2024
17 checks passed
@niccokunzmann
Copy link
Member

Tests running, beautiful! Thanks @mtr-d3v !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants