Pass Mill source JARs to Bloop #4608
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test right after tests the same thing and more
alexarchambault
changed the title
|
The Mill BSP server already adds those to the root modules. But using Bloop is handy sometimes. And if I'm not mistaken, I think using Bloop rather than BSP is still the default in Metals. |
|
Note that this fixes things for me… when I use my own local fork of Metals, not with Metals mainline. With mainline Metals, on a simple project, Bloop import is slightly better (hover works, not go-to-source). With BSP import, neither hover nor go-to-source work. That's with Mill 0.12.x at least (got to try with main, maybe the switch to Scala 3 helps). That's all on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to pass source JARs corresponding to the Mill class path to Bloop. These are added in the root modules, where they're needed to get go-to-source to work for Mill build files.