Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tesla Model 3/Y bugs + improvements #1718

Open
4 of 11 tasks
sshane opened this issue Feb 13, 2025 · 2 comments
Open
4 of 11 tasks

Tesla Model 3/Y bugs + improvements #1718

sshane opened this issue Feb 13, 2025 · 2 comments
Labels
bug car related to opendbc/car/ tesla

Comments

@sshane
Copy link
Contributor

sshane commented Feb 13, 2025

  • There are faults we don't handle with FSD long and openpilot lateral. We can 1) detect when FSD is turned on and warn user to switch to TACC, or 2) automatically send a message to switch to TACC (Hyundai CAN FD does something similar with the ADAS ECU).
  • Temporary steering fault when overriding lateral very forcefully. Does the fault signal go high with FSD? If so, ignore in this case, else figure out how to not fault the steering.
    • It does not fault in TACC, need to do the above! EDIT: I only tested with OP long
  • similar to above, if you override hard it temp faults then resumes steering. I think the autopilot ECU disables steering before this happens
  • When releasing after overriding above the set speed the car brakes aggressively - change to enabled to fix jerk
    "DAS_setSpeed": 0 if (accel < 0 or not active) else V_CRUISE_MAX,
  • better ignition signal - Tesla: update ignition signal for Model 3/Y panda#2153
  • implement cancel - Tesla: implement cruiseControl.cancel #1734
  • handle max lateral accel faulting EPAS Tesla faults when you request more than 3 m/s^2 #1760
  • test max lateral jerk
  • test stock AEB works
  • faults above 360 degrees - Tesla: fix high angle fault #1793
  • steering pressed is now too sensitive, activates lane changes on accident if going over bumps. adjust right in the middle with a higher threshold or longer time
@sshane sshane added car related to opendbc/car/ tesla labels Feb 13, 2025
@sshane sshane added this to the openpilot 0.9.9 milestone Feb 13, 2025
@sshane sshane changed the title Tesla HW4 improvements Tesla Model 3/Y improvements Feb 13, 2025
@adeebshihadeh adeebshihadeh changed the title Tesla Model 3/Y improvements Tesla Model 3/Y bugs + improvements Feb 15, 2025
@adeebshihadeh
Copy link
Contributor

adeebshihadeh commented Feb 15, 2025

@sshane sshane added the bug label Feb 17, 2025
@lukasloetkolben
Copy link
Contributor

  • Passthrough ASS / Autopark / Lane Keeping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug car related to opendbc/car/ tesla
Projects
None yet
Development

No branches or pull requests

3 participants