-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rhino8 gh #1427
base: main
Are you sure you want to change the base?
Rhino8 gh #1427
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1427 +/- ##
==========================================
- Coverage 61.83% 61.81% -0.03%
==========================================
Files 207 207
Lines 22310 22310
==========================================
- Hits 13795 13790 -5
- Misses 8515 8520 +5 ☔ View full report in Codecov by Sentry. |
Stoked about the yakerize feature! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YAY!!! LGTM! 🚀
Do we need to update the installation docs to indicate that 8.0 is not installable the same way or is it already updated?
part of #1351
needs compas-dev/compas_invocations2#4
compas_rhino.install -v8.0
What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas.datastructures.Mesh
.