Renamed a bunch of cached_robot
to cached_robot_model
in PyBulletClient
#428
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing naming convention calling the cached robot_model as robot is very confusing. I renamed it to explicitly say
cached_robot_model
.This is a breaking change for people who directly access the cached model, but I doubt anyone is doing that now.
PybulletClient.get_cached_robot
toPybulletClient.get_cached_robot_model
PybulletClient.ensure_cached_robot
toPybulletClient.ensure_cached_robot_model
.PybulletClient.ensure_cached_robot_geometry
toPybulletClient.ensure_cached_robot_model_geometry
.PybulletClient.cache_robot
toPybulletClient.cache_robot_model
.What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas_fab.robots.CollisionMesh
.