Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows build #21

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add windows build #21

wants to merge 4 commits into from

Conversation

pavelzw
Copy link
Member

@pavelzw pavelzw commented Nov 29, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

depends on conda-forge/lua-lpeg-feedstock#13

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found some lint.

Here's what I've got...

For recipe/recipe.yaml:

  • ❌ The top level meta key schema_version is unexpected
  • ❌ There are 1 too many lines. There should be one empty line at the end of the file.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12082970203. Examine the logs at this URL for more detail.

@danielnachun
Copy link
Contributor

I've merged conda-forge/lua-lpeg-feedstock#13, and will push fixes to this locally in a little bit after there has been enough time for the Windows build of lua-lpeg to become available.

Before merge I'm also going to test locally if there's any way to fix that permissions error in Windows that prevented the use of cmake install. If I can't figure it out quickly I'll just merge as is.

recipe/recipe.yaml Outdated Show resolved Hide resolved
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

@danielnachun
Copy link
Contributor

Well that's unexpected, now macOS and Windows are working but Linux is failing with this rather arcane error:

$SRC_DIR/src/nvim/po/ja.euc-jp.po: warning: Charset "EUC-JP" is not supported. msgfmt relies on iconv(), and iconv() does not support "EUC-JP". Installing GNU libiconv and then reinstalling GNU gettext would fix this problem. Continuing anyway.
$PREFIX/bin/msgfmt: Cannot convert from "EUC-JP" to "UTF-8". msgfmt relies on iconv(), and iconv() does not support this conversion.

I have added libiconv as a dependency on Linux but that doesn't actually fix the issue, so the suggested fix doesn't actually help. I'll continue debugging this locally to see if I can figure out the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants