Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyodide-build 0.29.0, add maintainers #20

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Sep 19, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Changes:

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@bollwyvl
Copy link
Contributor Author

@conda-forge-admin please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pyodide-build-feedstock/actions/runs/10942746217.

@agriyakhetarpal
Copy link
Member

Thank you! I affirm that I would like to be added.

@bollwyvl bollwyvl marked this pull request as ready for review September 19, 2024 14:28
@bollwyvl
Copy link
Contributor Author

Gotta do $DAY_JOB stuff, will check back in when i get the chance.

@bollwyvl
Copy link
Contributor Author

Back for a sec: with 100% more maintainers, we can push the others out to separate PRs (these can be automated with @conda-forge-admin please add maintainer @{who})

@bollwyvl
Copy link
Contributor Author

@conda-forge-admin please rerender

@bollwyvl bollwyvl added the automerge Merge the PR when CI passes label Sep 19, 2024
@github-actions github-actions bot merged commit 186d8eb into conda-forge:main Sep 19, 2024
3 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@agriyakhetarpal
Copy link
Member

Thanks for this, again! Separate PRs sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants