-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken pytorch version constraint #9
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Thank you @yit-b! Would you like to become a maintainer here? |
@conda-forge-admin please rerender |
…nda-forge-pinning 2024.04.30.19.10.24
@@ -66,7 +66,7 @@ requirements: | |||
- cudnn # [cuda_compiler_version != "None"] | |||
- numpy | |||
- pytorch | |||
- pytorch =*={{ torch_proc_type }}* | |||
- pytorch =*=*{{ torch_proc_type }}* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tobias-Fischer, we might actually want to revert this change as it would allow users to install pytorch
from the pytorch
channel as mentioned at conda-forge/mmcv-recipe-feedstock#31 (comment). I think @yit-b was trying to pull in a newer version of Pytorch according to #10, and wanted to relax this constraint to allow installing from the pytorch
channel, but we should actually be pushing for conda-forge to have a newer version of Pytorch 2.2 rather than allowing channel mixing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, good point, thanks for making me aware of this, I should have looked more carefully. Are you happy to open a PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, opened at #11.
When trying to install pytorch3d alongside a precise version of pytorch, the constraint on pytorch's build fails erroneously due to a missing leading asterisk in the run requirements/constraints. Builds that should be allowed are blocked.
Example repro using micromamba (also repros with bare conda, but it's so slow):
CONDA_OVERRIDE_CUDA is required since the meta.yaml places a requirement that the host has cuda installed, which is not necessary, but that's a different issue.
Result:
There is a constraint that the build begins with the string literal
cuda
. However, in reality pytorch builds are prefixed with the python version, followed by the cuda version. So the constraint should bepytorch * *cuda*
. This change is suggested in this PR.