Allow Namespace pydantic model to have a null metadata_ entry #1063
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1062
Description
This PR updates the pydantic model for
Namespace
so that themetadata_
field can be null. This field is nullable, and the default value is an empty dict:In order for pydantic models to allow values to be
None
, they must set them asOptional
. If not, an error will be thrown.In older deployments on conda-store it is possible for this field to actually be
NULL
(see the explanation #1062 (comment)), resulting in an error.Additional notes
While sorting this out I also checked for other orm fields that were explicitly set to
nullable=True
and ensured that their pydantic counterparts are set toOptional
.Pull request checklist