Version 2 #21
Merged
Version 2 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
November 19, 2018 05:12
added 2 commits
February 1, 2019 12:57
miafoo
commented
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for React translations, string templates, more.
Fixes #19
Fixes #3
Fixes #20
Fixes #2
TODO
[this].props.tfor allt,tn, etc...Fix missing keysConsider adding a number formatter to the provider, sotn(n, 'Last {n} day', 'Last {n} days')would formatncorrectly.Translations with spaces failTranslations with spaces fail #23t('Test ')vs.t('Test')CallingCreate basic ESLint plugin #24twith empty string crashes, throw error instead?Investigate crash when invalid language selectedFix crash on invalid langauge selected #25Only console log warnings and errors in developmentConsole errors and warnings should not happen in production #26Translations/TranslationSettype