Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip-ci] RPM/TMT: use tests subpackage #557

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[skip-ci] RPM/TMT: use tests subpackage #557

wants to merge 3 commits into from

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Dec 24, 2024

This makes fetching and running of gating tests similar to podman, buildah and skopeo.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5 lsm5 force-pushed the rpm-tests-subpackage branch 4 times, most recently from f29b9d0 to f5388be Compare December 25, 2024 15:20
@lsm5 lsm5 marked this pull request as ready for review December 25, 2024 15:36
Luap99
Luap99 reviewed Jan 7, 2025
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems fine, I cannot really comment on the tmt/gating specifics but having a test subpackage to run them in gating seems good.

rpm/aardvark-dns.spec Outdated
Comment on lines 62 to 63
# Only intended to be used for gating tests
# End user usecases not supported
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be part of the description? So end user have actually a chance to read it.

rpm/aardvark-dns.spec Outdated
Requires: jq
Requires: make
Requires: netavark
Requires: nftables
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't nftables already required by netavark?

rpm/aardvark-dns.spec Outdated
Requires: bind-utils
Requires: iptables
Requires: jq
Requires: make
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make doesn't seem to be needed to run as your script just calls bats test/

@lsm5 lsm5 marked this pull request as draft January 15, 2025 11:55
lsm5 added 2 commits January 28, 2025 16:59
@lsm5
RPM: include empty check section to silence rpmlint
7f536cd 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
[skip-ci] RPM/TMT: use tests subpackage
fed0226 
This makes fetching and running of gating tests similar to podman,
buildah and skopeo.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 force-pushed the rpm-tests-subpackage branch from f5388be to fed0226 Compare January 28, 2025 11:30
@packit-as-a-service Packit-as-a-Service
Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs[5].packages': 'Undefined package(s) referenced: podman-fedora.', 'jobs[7].packages': 'Undefined package(s) referenced: podman-fedora.'})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

2 similar comments
@packit-as-a-service Packit-as-a-Service
Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs[5].packages': 'Undefined package(s) referenced: podman-fedora.', 'jobs[7].packages': 'Undefined package(s) referenced: podman-fedora.'})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

@packit-as-a-service Packit-as-a-Service
Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs[5].packages': 'Undefined package(s) referenced: podman-fedora.', 'jobs[7].packages': 'Undefined package(s) referenced: podman-fedora.'})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

@lsm5 lsm5 force-pushed the rpm-tests-subpackage branch from c98aabf to 54f5bc3 Compare January 28, 2025 11:44
@packit-as-a-service Packit-as-a-Service
Copy link

Tests failed. @containers/packit-build please check.

@lsm5 lsm5 force-pushed the rpm-tests-subpackage branch 3 times, most recently from 11ade41 to 5fd0f63 Compare January 30, 2025 15:25
@lsm5
Packit/TMT: organize test plans based on rpm dependency
3396382 
Unit and validate tests don't need to depend on the built rpm and it's
sufficient to run them on only 1 target.

So, it's more convenient to re-org the test plans based on rpm
dependency.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 force-pushed the rpm-tests-subpackage branch from 5fd0f63 to 3396382 Compare January 30, 2025 15:59
@lsm5
Copy link
Member Author

lsm5 commented Jan 30, 2025

@Luap99 cs9 and f40 tests are failing on not finding nft. Are the tests there expected to fail without nftables? IIUC, the default_fw is nftables only on f41+ and cs10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luap99 Luap99 Luap99 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
approved do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsm5 @Luap99