buildah/push/manifest-push: add support for --force-compression to prevent reusing other blobs
#4973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mtrmac FYI, although I still need to update docs but other than that most of the code and tests are done. |
mtrmac
reviewed
Aug 11, 2023
flouthoc
force-pushed
the
force-compression
branch
2 times, most recently
from
ab3d461 to
4aec38a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
docs/buildah-manifest-push.1.md
Outdated
| @@ -52,6 +62,10 @@ value can be entered. The password is entered without echo. | |||
|
|
|||
| After copying the image, write the digest of the resulting image to the file. | |||
|
|
|||
| **--force-compression** | |||
|
|
|||
| Use the specified compression algorithm if the destination contains a differently-compressed variant already. | |||
There was a problem hiding this comment.
I think?
Suggested change
| Use the specified compression algorithm if the destination contains a differently-compressed variant already. | |
| Use the specified compression algorithm even if the destination contains a differently-compressed variant already. |
docs/buildah-push.1.md
Outdated
| @@ -70,6 +70,10 @@ Layer(s) to encrypt: 0-indexed layer indices with support for negative indexing | |||
|
|
|||
| The [protocol:keyfile] specifies the encryption protocol, which can be JWE (RFC7516), PGP (RFC4880), and PKCS7 (RFC2315) and the key material required for image encryption. For instance, jwe:/path/to/key.pem or pgp:[email protected] or pkcs7:/path/to/x509-file. | |||
|
|
|||
| **--force-compression** | |||
|
|
|||
| Use the specified compression algorithm if the destination contains a differently-compressed variant already. | |||
|
/lgtm |
Signed-off-by: Aditya R <[email protected]>
Adds support for `--force-compression` which allows end-users to force push blobs with the selected compresison in `--compression` option, in order to make sure that `blobs` of other compression on registry are not reused. Is equivalent to: `force-compression` here: https://docs.docker.com/build/exporters/#compression Closes: containers#4613 Also Implements: `--compression-format` and `--compression-level` for `manifest push` just like `podman`'s `manifest push` Signed-off-by: Aditya R <[email protected]>
flouthoc
force-pushed
the
force-compression
branch
from
4aec38a to
d68d9a2
Compare
|
@rhatdan I think this will need |
|
LGTM |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
--force-compressionwhich allows end-users to forcepush blobs with the selected compresison in
--compressionoption, inorder to make sure that
blobsof other compression on registry are notreused.
Is equivalent to:
force-compressionhere: https://docs.docker.com/build/exporters/#compressionCloses: #4613
Also Implements:
--compression-formatand--compression-levelformanifest pushjust likepodman'smanifest push