-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert PR #339 #467
Revert PR #339 #467
Conversation
…ge()" fn." This reverts commit 58eb054 Due to numerous issues related to getting DNS configuration we're returning back usage of system dns resolver Signed-off-by: Yevhen Vydolob <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evidolob The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok. We also need to remove the libhosty
that was introduced by 3ea66d1#diff-36413b7f6d90caa4614ea1ff2143885144294078b84dd0d981e221241672f024
Due to reverting PR containers#339 thous files is not used Signed-off-by: Yevhen Vydolob <[email protected]>
Thx @lstocchi, I've deleted unused dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I'll let @cfergeau merges it so he can give it a look as well. I just compared with the old version, maybe his historical knowledge lets him remember something else |
6436c51
into
containers:main
AH I thought that I also needed to type |
Due to numerous issues with DNS resolution we decided to revert changes made in #339
More info in #466