Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR #339 #467

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Revert PR #339 #467

merged 2 commits into from
Jan 29, 2025

Conversation

evidolob
Copy link
Collaborator

Due to numerous issues with DNS resolution we decided to revert changes made in #339

More info in #466

…ge()" fn."

This reverts commit 58eb054

Due to numerous issues related to getting DNS configuration we're returning back usage of system dns resolver

Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob evidolob requested review from cfergeau and lstocchi January 29, 2025 09:25
Copy link
Contributor

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evidolob

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok. We also need to remove the libhosty that was introduced by 3ea66d1#diff-36413b7f6d90caa4614ea1ff2143885144294078b84dd0d981e221241672f024

Due to reverting PR containers#339 thous files is not used

Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob
Copy link
Collaborator Author

Thx @lstocchi, I've deleted unused dependencies

@evidolob evidolob requested a review from lstocchi January 29, 2025 09:55
Copy link
Collaborator

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lstocchi
Copy link
Collaborator

I'll let @cfergeau merges it so he can give it a look as well. I just compared with the old version, maybe his historical knowledge lets him remember something else

@openshift-merge-bot openshift-merge-bot bot merged commit 6436c51 into containers:main Jan 29, 2025
19 of 20 checks passed
@lstocchi
Copy link
Collaborator

AH I thought that I also needed to type /approve to get this merged but as you also are an approver the /lgtm is enough to merge 😓 @cfergeau please give it a look anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants