fix(generate): accept array or object from podman inspect output
#111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Podman v5.0.0 and newer always returns an array from `podman inspect`. Older versions of Podman may return a single JSON object if there is only one result, notably for `podman pod inspect`. Created a `serde::de::Visitor` for deserializing the output of `podman inspect` which accepts a map (object) or sequence (array). Tested with both Podman v5.2.2 and v4.9.4 (via quay.io/containers/podman:v4.9.4 image). Fixes: #94 Signed-off-by: Paul Nettleton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Podman v5.0.0 and newer always returns an array from
podman inspect. Older versions of Podman may return a single JSON object if there is only one result, notably forpodman pod inspect.Created a
serde::de::Visitorfor deserializing the output ofpodman inspectwhich accepts a map (object) or sequence (array).Tested with both Podman v5.2.2 and v4.9.4 (via quay.io/containers/podman:v4.9.4 image).
Fixes: #94