-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #398: exclude deps on up if --no-deps #1108
Conversation
Thanks for the PR. It looks good. Please a release note to the newsfragments directory (you can look here for inspiration on how release note looks like). Also the PR needs an integration test. In this particular case I think |
088ff46
to
baf2e48
Compare
Thanks for the hints! The integration test exposed that it is a bit more involved than I thought initially (my local setup didn't trigger these).
|
podman_compose.py
Outdated
if podman_command == "run" and subproc is not None: | ||
await run_container(compose, cnt["name"], cnt["_deps"], ([], "start", [cnt["name"]])) | ||
await run_container(compose, cnt["name"], deps, ([], "start", [cnt["name"]])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add
def deps_from_container(args, cnt):
if args.no_deps:
return set()
return cnt['deps']
and call it here and in the call site below.
Great to see tests had good impact :) The PR looks good overall, I had one nit comment. Another nit comment, could you move Thanks a lot! |
Fixes containers#717. Signed-off-by: Emanuel Rietveld <[email protected]>
Fixes containers#398. Signed-off-by: Emanuel Rietveld <[email protected]>
Fixes #398 by excluding dependent services if --no-deps is given on the command line.