-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove incorrect os.chdir, handle relative extends/includes #1124
Conversation
Seems like this broke integration tests, maybe the fix should be to make all files absolute before the loop? |
Probably. This needs checking. |
838765e
to
869aaef
Compare
@p12tic looks like the issue was with handling of relative imports, used absolute paths for services and includes, tests are passing now |
869aaef
to
db53342
Compare
Looks good in principle, thanks! Several small issues:
|
the chdir and services/includes are related, you can't have one without the other, if you think otherwise, I can split them. |
You're right, my head is not working. |
I have confirmed that this fixes #1109 for my use cases. |
@p12tic can we release this? |
Signed-off-by: notdian <[email protected]>
0a78aba
to
e03d675
Compare
Rebased. |
Running
docker-compose -f containers/base
resulted in aFileNotFoundError
. However, it worked aftercd containers
and then runningdocker-compose -f base
. It appears that the removal ofchdir
operation was overlooked.