Implement x-podman.pod_args to override --pod-args default #1133
+229
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neocturne
force-pushed
the
pod-args
branch
2 times, most recently
from
d6cb71a to
0abb47b
Compare
p12tic
reviewed
Feb 7, 2025
p12tic
reviewed
Feb 7, 2025
p12tic
reviewed
Feb 7, 2025
p12tic
requested changes
Feb 7, 2025
neocturne
force-pushed
the
pod-args
branch
2 times, most recently
from
7e1f33e to
ace2c40
Compare
Allow setting an argument list as x-podman.pod_args to override the default value `--infra=false --share=`. `--pod-args` passed on the command line takes precedence over the value set in docker-compose.yml; the values are not merged. Fixes containers#1057. Signed-off-by: Matthias Schiffer <[email protected]>
p12tic
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting an argument list as x-podman.pod_args to override the default value
--infra=false --share=.--pod-argspassed on the command line takes precedence over the value set in docker-compose.yml; the values are not merged.Fixes #1057.
Signed-off-by: Matthias Schiffer [email protected]