Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding monaco support #2281

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

axel7083
Copy link
Contributor

What does this PR do?

Tentative to add the Monaco Editor to AI Lab. We cannot do dynamic import because it crashes (no idea why, probably related to the way we manage webview webserver.)

Known issues

  • Cannot use the Monaco editor in tests (vitest) got lots of errors (The Podman Destkop Monaco Editor seems to also have some similar issues, because it has no tests too.)
  • Some languages (javascript) are not recognised (probably some naming issues, this should be in a follow-up PR)

Screenshot / video of UI

image

image

What issues does this PR fix or reference?

Fixes #858

How to test this PR?

  1. Start an inference service
  2. Go to inference details page
  3. assert monaco editor in readonly.

@axel7083 axel7083 requested review from benoitf, jeffmaury and a team as code owners December 18, 2024 14:41
Copy link
Contributor

@gastoner gastoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant write to the editor ✅
But when I try to type something, the editor starts shifting, resulting into this:

Screen.Recording.2024-12-18.194132.mp4

@axel7083
Copy link
Contributor Author

But when I try to type something, the editor starts shifting, resulting into this:

WHattttttt, love how monaco editor handle readonly will take a look

@axel7083 axel7083 marked this pull request as draft December 19, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add syntax highlighting to client code in service details
2 participants