AI Lab Recipe Catalog change test pipeline #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbr7
approved these changes
Jan 13, 2025
odockal
requested changes
Jan 13, 2025
gastoner
approved these changes
Jan 13, 2025
odockal
requested changes
Jan 13, 2025
ScrewTSW
force-pushed
the
2134-run-recipe-tests-on-catalog-change
branch
5 times, most recently
from
164664d to
322d85a
Compare
Signed-off-by: Tibor Dancs <[email protected]>
ScrewTSW
force-pushed
the
2134-run-recipe-tests-on-catalog-change
branch
from
322d85a to
ba4c97d
Compare
odockal
requested changes
Jan 21, 2025
| windows: | ||
| name: recipe-catalog-windows-${{ matrix.windows-version }}-${{ matrix.windows-featurepack }} | ||
| runs-on: ubuntu-latest | ||
| permissions: |
There was a problem hiding this comment.
remove permission, no need if annontate_only: true is set.
| uses: mikepenz/action-junit-report@v5 | ||
| if: always() # always run even if the previous step fails | ||
| with: | ||
| fail_on_failure: true |
| -start ${{ env.PODMAN_START }} \ | ||
| -userNetworking ${{ env.PODMAN_NETWORKING }} \ | ||
| -envVars ${{ env.ENV_VARS }} \ | ||
| -runAsAdmin ${{ env.PODMAN_ADMIN }} \ |
There was a problem hiding this comment.
env var is not set anywhere. I would not call it PODMAN, just RUN_AS_ADMIN. Remove the backslash.
There was a problem hiding this comment.
shouldn't this be parsed by this though?
DEFAULT_PODMAN_OPTIONS: 'INIT=1,START=1,ROOTFUL=1,NETWORKING=0,ADMIN=1'
...
echo "${{ env.DEFAULT_PODMAN_OPTIONS }}" | awk -F ',' \
'{for (i=1; i<=NF; i++) {split($i, kv, "="); print "PODMAN_"kv[1]"="kv[2]}}' >> $GITHUB_ENV
There was a problem hiding this comment.
we should not hide it within podman setup parameters.
ScrewTSW
force-pushed
the
2134-run-recipe-tests-on-catalog-change
branch
2 times, most recently
from
3241de5 to
d2d7417
Compare
Signed-off-by: Tibor Dancs <[email protected]>
ScrewTSW
force-pushed
the
2134-run-recipe-tests-on-catalog-change
branch
from
d2d7417 to
78fb086
Compare
odockal
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
#2134
How to test this PR?
packages/backend/src/assets/ai.json(e.g.: duplicate an entry)Run recipe tests on catalog changeshould trigger