Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Recipe catalog tests - fixing typo, parametrizing template #2418

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ScrewTSW
Copy link
Member

What does this PR do?

  • Fixes typo in parameter name on trigger job
  • Parametrizes the template so it can be re-used from other jobs

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

Closes #2134

How to test this PR?

  • change packages/backend/src/assets/ai.json
  • open a PR

@ScrewTSW ScrewTSW requested review from benoitf, jeffmaury and a team as code owners January 22, 2025 09:38
@ScrewTSW ScrewTSW requested review from cdrage and deboer-tim January 22, 2025 09:38
@@ -21,6 +21,26 @@
"languages": ["python"],
"frameworks": ["streamlit", "langchain"]
},
{
"id": "chatbot2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why adding this recipe?

Copy link
Contributor

@odockal odockal Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is just temporary change to test PR with a trigger.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to test triggering the workflow, it will be removed

@ScrewTSW ScrewTSW force-pushed the 2134-run-recipe-tests-on-catalog-change branch 6 times, most recently from 763fa7c to 61fb4e9 Compare January 22, 2025 10:23
@ScrewTSW ScrewTSW changed the title Recipe catalog tests - fixing typo, parametrizing template WIP: Recipe catalog tests - fixing typo, parametrizing template Jan 22, 2025
@ScrewTSW ScrewTSW marked this pull request as draft January 22, 2025 15:19
@ScrewTSW ScrewTSW force-pushed the 2134-run-recipe-tests-on-catalog-change branch from 61fb4e9 to 8ff4f5f Compare January 29, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement GHA workflow with a trigger on recipes change
3 participants