-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: alow to show model metrics in playground #2477
feat: alow to show model metrics in playground #2477
Conversation
ad79c32
to
a762440
Compare
Need to rebase after #2480 is merged |
a762440
to
5ddd6ac
Compare
2b9eed0
to
264b263
Compare
@@ -208,7 +209,7 @@ export class PlaygroundV2Manager implements Disposable { | |||
throw new Error( | |||
`modelId '${conversation.modelId}' is not available on the inference server, valid model ids are: ${server.models.map(model => model.id).join(', ')}.`, | |||
); | |||
|
|||
console.error(options); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to remove?
"vulkan": "ghcr.io/containers/podman-desktop-extension-ai-lab-playground-images/ai-lab-playground-chat-vulkan@sha256:22e11661fe66ace7c30b419703305b803eb937da10e19c23cb6767f03578256c" | ||
"default": "ghcr.io/containers/podman-desktop-extension-ai-lab-playground-images/ai-lab-playground-chat@sha256:2eb6cd7a4c4f76e54eeb88465281f4ff2a8f7b7e49db893a579a8f6842f69eb1", | ||
"cuda": "ghcr.io/containers/podman-desktop-extension-ai-lab-playground-images/ai-lab-playground-chat-cuda@sha256:e4b57e52c31b379b4a73f8e9536bc130fdea665d88dbd05643350295b3402a2f", | ||
"vulkan": "ghcr.io/containers/podman-desktop-extension-ai-lab-playground-images/ai-lab-playground-chat-vulkan@sha256:6a93b247099643f4f8c78ee9896c2ce4e9a455af114a69be09c16ad36aa51fd2" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do that in a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #2491
264b263
to
9ae4c04
Compare
if (messageIndex === -1) | ||
throw new Error(`message with id ${messageId} does not exist in conversation ${conversationId}.`); | ||
|
||
console.warn(messageIndex, usage); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why console.warn here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need some unit tests, but LGTM
Signed-off-by: Evzen Gasta <[email protected]>
9ae4c04
to
607fe7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Evzen Gasta <[email protected]>
What does this PR do?
Shows metrics of a model in playground
Screenshot / video of UI
Untitled.video.-.Made.with.Clipchamp.4.mp4
What issues does this PR fix or reference?
Closes #438
How to test this PR?