-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sec): upgrade github.com/sigstore/rekor to 1.2.0 #18813
fix(sec): upgrade github.com/sigstore/rekor to 1.2.0 #18813
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chncaption The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributions need a valid DCO. Considering that this change does not touch any code here I assume our code does not use the effected code. Also I don't think we have to bump indirect dependencies unless absolutely necessary. I would assume the normal c/image update will result in a update here so I don't think we need this. |
Yes.
I assume that’s because the PR is incorrect. Podman does include that code but doesn’t run it.
That’s one way of dealing with this. Another is to follow #18709 , and Chris’ effort to have indirect dependency PRs automatically filed by Renovate. I think getting that process working is more useful than even just thinking whether we should spend any effort on getting this PR into a mergeable state. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Should be fixed in #18835 so we can close this one |
What happened?
There are 1 security vulnerabilities found in github.com/sigstore/rekor v1.1.2-0.20230508234306-ad288b385a44
What did I do?
Upgrade github.com/sigstore/rekor from v1.1.2-0.20230508234306-ad288b385a44 to 1.2.0 for vulnerability fix
What did you expect to happen?
Ideally, no insecure libs should be used.
The specification of the pull request
PR Specification from OSCS