Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bundled krunkit to 0.1.4 #24563

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

slp
Copy link
Contributor

@slp slp commented Nov 14, 2024

Bump the bundled krunkit version from 0.1.3 to 0.1.4.

Fixes: #24559

Does this PR introduce a user-facing change?

Update krunkit in the macos installer to 0.1.4 to fix an issue where libkrun machines failed to start.

Bump the bundled krunkit version from 0.1.3 to 0.1.4.

Fixes: containers#24559

Signed-off-by: Sergio Lopez <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Nov 14, 2024
@baude
Copy link
Member

baude commented Nov 14, 2024

/approve

LGTM

Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, slp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2024
@mheon
Copy link
Member

mheon commented Nov 14, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2024
@mheon
Copy link
Member

mheon commented Nov 14, 2024

@Luap99 Should we be replacing krunkit in the CI VMs here as well?

@Luap99
Copy link
Member

Luap99 commented Nov 14, 2024

@Luap99 Should we be replacing krunkit in the CI VMs here as well?

This is installed via brew and updated automatically when the worker are recreated every two days or so, https://issues.redhat.com/browse/RUN-2276
We do not test our macos installer anywhere in CI (and I don't know how as we can never expose root access to our worker for obvious reasons as installing a .pkg requires root)

@openshift-ci openshift-ci bot added release-note and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Nov 14, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 777a997 into containers:main Nov 14, 2024
25 of 38 checks passed
@Luap99
Copy link
Member

Luap99 commented Nov 14, 2024

/cherry-pick v5.3

@openshift-cherrypick-robot
Copy link
Collaborator

@Luap99: new pull request created: #24564

In response to this:

/cherry-pick v5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Feb 13, 2025
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to create/run a podman machine using libkrun provider with podman 5.3.0
5 participants